-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Enhancement] Add enable_optimizer_rule_debug session variable for rule failure diagnosis #63693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1ad9dc to
03fd0fa
Compare
26fc032 to
5b4e270
Compare
9a28a08 to
50c87ab
Compare
50c87ab to
dc55613
Compare
Signed-off-by: stephen <[email protected]>
dc55613 to
793763c
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 45 / 48 (93.75%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kangkaisen
approved these changes
Oct 23, 2025
Seaven
approved these changes
Oct 23, 2025
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.5 |
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-4.0 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
…le failure diagnosis (#63693) Signed-off-by: stephen <[email protected]> (cherry picked from commit 6a318c2)
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
…le failure diagnosis (#63693) Signed-off-by: stephen <[email protected]> (cherry picked from commit 6a318c2) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/QueryOptimizer.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/task/RewriteTreeTask.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/task/TaskContext.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/GroupingSetsTest.java
23 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
…le failure diagnosis (#63693) Signed-off-by: stephen <[email protected]> (cherry picked from commit 6a318c2) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/QueryOptimizer.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/task/RewriteTreeTask.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/task/TaskContext.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/GroupingSetsTest.java
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
…le failure diagnosis (#63693) Signed-off-by: stephen <[email protected]> (cherry picked from commit 6a318c2)
23 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 25, 2025
…le failure diagnosis (backport #63693) (#64488) Signed-off-by: stephen <[email protected]> Co-authored-by: stephen <[email protected]> Co-authored-by: stephen <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Oct 25, 2025
…le failure diagnosis (backport #63693) (#64485) Signed-off-by: stephen <[email protected]> Co-authored-by: stephen <[email protected]> Co-authored-by: stephen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Why I'm doing:
Currently, when optimizer rules encounter bugs, users often see cryptic error messages like
Error 1064 (HY000): only found column statistics: {353: sum, 3}without knowing which specific rule caused the problem. This makes troubleshooting extremely difficult in production environments, as users cannot identify the problematic rule to apply workarounds.When optimizer rules fail, especially during complex query optimization phases, the error messages lack context about which transformation or validation rule triggered the failure. This creates significant challenges for both users and developers in diagnosing and resolving optimizer-related issues.
What I'm doing:
This PR introduces a new session variable
enable_optimizer_rule_debugto provide detailed debugging information when optimizer rules fail. The enhancement includes:New Session Variable:
enable_optimizer_rule_debugcbo_disabled_rulesfeature from PR #64269 to provide users with immediate workaroundsUsage Example:
--Rerun the failed query. When a rule fails, you'll see detailed output like:
-- Combined with cbo_disabled_rules for workarounds:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: